[Snippets] Introduce SNIPPETS_API macro #32335
Open
+204
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: snippets
category: build
aobolensk
force-pushed
the
snippets-visibility
branch
from
c3bdb06 to
75df1ad
Compare
aobolensk
force-pushed
the
snippets-visibility
branch
5 times, most recently
from
41d8f95 to
bf9fdfb
Compare
allnes
approved these changes
Oct 14, 2025
v-Golubev
requested changes
Oct 23, 2025
There was a problem hiding this comment.
During an offline discussion in the sync, we concluded that exporting an entire snippets opset is not a viable option. Doing so would allow users to create internal snippet ops, which should not be permitted.
The agreed proposal is to investigate the root cause of why only Android requires exported ops to be matched in MatcherPass—for example, due to specific compilation flags—and attempt to eliminate that root cause.
For now, it has been agreed to disable snippets on Android (#32518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
SNIPPETS_APImacro to properly export snippet specific opset and set of passesTickets: