Skip to content

[NPU] Accept blobs compiled with a limited set of minor version #32532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[NPU] Accept blobs compiled with a limited set of minor version #32532

wants to merge 8 commits into from
+102 −115

Conversation

@alexandruenache1111
Copy link
Contributor

@alexandruenache1111 alexandruenache1111 commented Oct 23, 2025 •
edited
Loading

Details:

  • Minor version will be increased in the next OV release. Blobs compiled with the future OpenVINO version should not be accepted.

Tickets:

  • n/a

@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Oct 23, 2025
@alexandruenache1111 alexandruenache1111 changed the title [NPU] Simplify blob version skip logic [NPU] Accept blobs compiled with a limited set of minor version Oct 23, 2025
@alexandruenache1111 alexandruenache1111 self-assigned this Oct 23, 2025
@alexandruenache1111
Clang format
043f783 
Signed-off-by: alexandruenache1111 <[email protected]>
@alexandruenache1111 alexandruenache1111 marked this pull request as ready for review October 23, 2025 12:04
@alexandruenache1111 alexandruenache1111 requested review from a team as code owners October 23, 2025 12:04
pereanub
pereanub reviewed Oct 24, 2025
View reviewed changes
src/plugins/intel_npu/src/plugin/src/metadata.cpp
std::unique_ptr<MetadataBase> storedMeta;
storedMeta = create_metadata(metaVersion, blobDataSize);
storedMeta->read(stream);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this try-catch mechanism here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because create_metadata or read may throw exceptions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you just throw the exceptions further. You don't handle them.

Copy link
Contributor Author

@alexandruenache1111 alexandruenache1111 Oct 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I am not a fan of passing exceptions along the function stack. However, the motivation here would be to "append exception messages until one is not handled and the execution is halted".

src/plugins/intel_npu/src/plugin/src/metadata.cpp
CURRENT_METADATA_MAJOR_VERSION,
".",
CURRENT_METADATA_MINOR_VERSION);
OPENVINO_THROW(ex.what());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pereanub pereanub pereanub left review comments

@sbutnari sbutnari sbutnari approved these changes

Assignees

@alexandruenache1111 alexandruenache1111

Labels

category: NPU OpenVINO NPU plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandruenache1111 @pereanub @sbutnari