Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astra Linux variants (streebog) fail on BE #5535

Closed
claudioandre-br opened this issue Sep 14, 2024 · 4 comments · Fixed by #5551
Closed

Astra Linux variants (streebog) fail on BE #5535

claudioandre-br opened this issue Sep 14, 2024 · 4 comments · Fixed by #5551

Comments

@claudioandre-br
Copy link
Member

We can fix or disable them on BE.

Testing: streebog256crypt, Astra Linux $gost12256hash$ (rounds=5000) [GOST R 34.11-2012 64/64]... (4xOMP) FAILED (cmp_all(64))
Testing: streebog512crypt, Astra Linux $gost12512hash$ (rounds=5000) [GOST R 34.11-2012 64/64]... (4xOMP) FAILED (cmp_all(64))
Testing: gost94crypt, Astra Linux $gost94hash$ (rounds=5000) [GOST R 34.11-94 32/64]... (4xOMP) PASS
[...]
Testing: crypt, generic crypt(3) [?/64]... (4xOMP) PASS
2 out of 410 tests have FAILED
 FAILED: -test-full=0 --format=cpu
Target CPU ......................................... s390x, 64-bit BE
AES-NI support ..................................... no
Target OS .......................................... linux-gnu
Cross compiling .................................... no
Legacy arch header ................................. autoconf_arch.h
Version: 1.9.0-jumbo-1+bleeding-07aef97db6 2024-09-13 18:57:07 +0200
Build: linux-gnu 64-bit s390x  AC OMP
System-wide exec: /snap/john-the-ripper/current/bin
System-wide home: /snap/john-the-ripper/current/bin
Private home: ~/.john
OMP fallback binary: john-s390x
$JOHN is /snap/john-the-ripper/current/bin/
@magnumripper
Copy link
Member

I used our existing GOST 2012 code - do other formats using it work on BE?

The rest (of non GPU stuff) is based on old (unoptimized and close to RFC) sha(256|512)crypt code also from our own repo, that I would think should work fine on BE but we might want to investigate Git history for that.

@claudioandre-br
Copy link
Member Author

The GOST results are:

$ grep -i gost < tmpkr98r4tc.buildlog 
:: Testing: gost, GOST R 34.11-94 [32/64]... (4xOMP) PASS
:: Testing: streebog256crypt, Astra Linux $gost12256hash$ (rounds=5000) [GOST R 34.11-2012 64/64]... (4xOMP) FAILED (cmp_all(64))
:: Testing: streebog512crypt, Astra Linux $gost12512hash$ (rounds=5000) [GOST R 34.11-2012 64/64]... (4xOMP) FAILED (cmp_all(64))
:: Testing: gost94crypt, Astra Linux $gost94hash$ (rounds=5000) [GOST R 34.11-94 32/64]... (4xOMP) PASS
:: Testing: dynamic_90 [gost($p) 32/64]... PASS
:: Testing: dynamic_1031 [gost($p) (hash truncated to length 32) 32/64]... PASS

@magnumripper
Copy link
Member

Found it: 9fe8768

@solardiz
Copy link
Member

Found it: 9fe8768

Yes, so we should either disable the Streebog-based crypts on BE or fix the underlying issue. @magnumripper Are you going to send a PR doing at least the former, please? Thank you!

@magnumripper magnumripper self-assigned this Sep 24, 2024
magnumripper added a commit to magnumripper/john that referenced this issue Nov 1, 2024
The problem is not in these formats but in our shared Streebog code.
It has clauses for BE but apparently they don't cut it.

Closes openwall#5535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants