Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streebog*crypt formats: Disable for BE builds #5551

Merged

Conversation

magnumripper
Copy link
Member

The problem is not in these formats but in our shared Streebog code. It has clauses for BE but apparently they don't cut it.

Closes #5535

The problem is not in these formats but in our shared Streebog code.
It has clauses for BE but apparently they don't cut it.

Closes openwall#5535
Copy link
Member

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and is consistent with how we do it in other formats, but separately (after this is merged) we could want to clean them all up not to use this #if !defined(FMT_EXTERNS_H) && !defined(FMT_REGISTERS_H) construct, instead moving the little-endian check and warning to inside the existing main code block before #endif /* plugin stanza */.

@solardiz
Copy link
Member

solardiz commented Nov 2, 2024

separately (after this is merged)

... or as a second commit here, I don't mind.

@magnumripper
Copy link
Member Author

Looks good to me and is consistent with how we do it in other formats, but separately (after this is merged) we could want to clean them all up not to use this #if !defined(FMT_EXTERNS_H) && !defined(FMT_REGISTERS_H) construct, instead moving the little-endian check and warning to inside the existing main code block before #endif /* plugin stanza */.

I can't figure out what you mean. For big endian, we need to define away the whole format including the plugin stuff. So we need the check at the very start of the file.

@magnumripper magnumripper merged commit 6a7d140 into openwall:bleeding-jumbo Nov 2, 2024
25 of 30 checks passed
@magnumripper magnumripper deleted the gostcrypt-disable-be branch November 2, 2024 01:22
@solardiz
Copy link
Member

solardiz commented Nov 2, 2024

For big endian, we need to define away the whole format including the plugin stuff. So we need the check at the very start of the file.

Oh, you're right, and I was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astra Linux variants (streebog) fail on BE
2 participants