Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: recommend pycryptodome package over PyCrypto #5478

Merged
merged 1 commit into from
May 16, 2024
Merged

python: recommend pycryptodome package over PyCrypto #5478

merged 1 commit into from
May 16, 2024

Conversation

exploide
Copy link
Contributor

The PyCrypto package is old and deprecated, pycryptodome works as a drop-in replacement with the same API.

@exploide
python: recommend pycryptodome package over PyCrypto
b8d0dd9 
PyCrypto is old and deprecated, pycryptodome works as a drop-in replacement
@solardiz
Copy link
Member

Thanks. I see DPAPImk2john.py is currently claimed to be both Python 2 and 3 compatible, which is great. I wonder if switching it to the new module dependency possibly excludes Python 2 support - in other words, is there pycryptodome for Python 2?

@exploide
Copy link
Contributor Author

Valid point. I just checked and it is available for Python 2, too. So no problem here.

@solardiz solardiz merged commit 332d43c into openwall:bleeding-jumbo May 16, 2024
31 of 32 checks passed
@solardiz solardiz mentioned this pull request May 16, 2024
Merged
@exploide exploide deleted the pycryptodome branch May 16, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exploide @solardiz