pcap2john.py: improvements for htdigest, gadu, cleanup #5508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization the prior implementation was not compatible with python3 and crashed on pcapng files. the new implementation also outputs basic auth credentials.
|
Thank you very much for your contributions, @exploide! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some enhancements for
pcap2john.py.Rewrote
pcap_parser_htdigestfunction to use scapy for parsing. Prior to this change, it was crashing on pcapng files (as opposed to pcap). Furthermore, it was not compatible with Python 3, now it is. While I was at it, I decided to print Basic Auth credentials directly to stderr. Could be interesting too, but no cracking required. Renamed the function topcap_parser_http_authorizationin this course. Since there was no example file for testing I created Added example capture for HTTP Authorization header john-samples#26.A cleanup commit removes an annoying call to
sleepand adds a few comments.Accidentally, I discovered
pcap_parser_gaduwas not compatible with Python 3, now it is. I refactored the function a bit to make it more conformant to the remainder of the script. Tested with the available sample files.