Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for PDF, and a couple of minor tweaks #5532

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

magnumripper
Copy link
Member

  • PDF format: Bug fixes for R3 with RC4-40
  • pbkdf2-hmac-sha256: Support MIME Base64
  • loader.c: Fix a bug which garbled encodings for --show=formats

Copy link
Member

@solardiz solardiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's weird that we have optimized scalar MD5 here - I guess we could have so much more speedup by using SIMD. But indeed we already had that and if it was wrong for some inputs, we should fix that first - like you do.

src/pbkdf2_hmac_common_plug.c Show resolved Hide resolved
src/pbkdf2_hmac_common_plug.c Outdated Show resolved Hide resolved
The 50x MD5 loop was hardcoded for 128 bits, which is not always correct.
@magnumripper magnumripper merged commit 07aef97 into openwall:bleeding-jumbo Sep 13, 2024
31 of 32 checks passed
@magnumripper magnumripper deleted the assorted branch September 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants