-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astra Linux crypt variants using GOST R 34.11-94 or GOST R 34.11-2012 #5533
Conversation
7a7522e
to
ae36e0b
Compare
The former is 256-bit. The latter is 256 or 512-bit and also known as Streebog. The formats exactly match Drepper's sha256crypt and sha512crypt but with the hash primitive replaced with one of the GOST alternatives. gost94crypt ($gost94hash$) streebog256crypt ($gost12256hash$) streebog512crypt ($gost12512hash$)
ae36e0b
to
f21b17e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's get these in, although I doubt all 3 are in active use.
#endif | ||
|
||
/* Repeatedly run the collected hash value through Streebog to burn CPU cycles. */ | ||
#pragma unroll HASH_LOOPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this unroll produces truly a lot of code. We should be able to optimize this without so much code later (not in this PR).
What's with the circleci stall? Should I ignore it and merge? I can't seem to click it for looking into it.
Yeah, best have a version with readable code in history before going crazy with it. Actually, I based these CPU formats on pristine versions of sha256crypt and sha512crypt formats from our Git history, that was handy for sure (before that, I tried basing it on the current versions with Jim's tweaks but something failed and I lost interest). |
Same here. I think yes, you should ignore it and merge. Thank you! |
The "stall" means that an administrator must review the (branch protection) rules. As seen in:
The |
I've just removed it from required checks, and somehow this resulted in it disappearing from pending checks completely. I have no idea why it was getting stalled lately nor why it disappeared completely when not required. |
Just to let you know in case you get stuck and bored in an airport:
Various formats work there:
It is Intel CPU driver:
|
The former is 256-bit. The latter is 256 or 512-bit and also known as Streebog. The formats exactly match Drepper's sha256crypt and sha512crypt, with the hash primitive replaced with one of the GOST alternatives.
gost94crypt (
$gost94hash$
)streebog256crypt (
$gost12256hash$
)streebog512crypt (
$gost12512hash$
)