Skip to content

bitcoin2john.py: SQLite3 format support #5770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: bleeding-jumbo
Choose a base branch
from

Conversation

mmcx
Copy link

@mmcx mmcx commented May 17, 2025

This PR add support SQLite3 format for wallet.dat
see: bitcoin/bitcoin#19077

@solardiz
Copy link
Member

Thank you for the contribution!

Can you please also add your copyright statement, and an update to doc/NEWS?

Then as a separate change (at least separate commit, and probably separate PR) you could move the import of the two database modules (or at least of one of them, perhaps BDB given the way you currently check for SQLite via the module) to be done conditionally only upon detecting that database type.

Please also provide a sample wallet file (with no coins in the wallet) with a known password, ideally via a PR to https://github.com/openwall/john-samples

@mmcx
Copy link
Author

mmcx commented May 17, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants