Iterated sha1 #5899
Open
Iterated sha1 #5899
+1,765
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salted-sha1 and SSHA512 are ($p.$s) XSHA and XSHA512 are ($s.$p)
This is optionally salted ($s.$p) and optionally iterated. Canonical ciphertext: $sisha1$iter$<salt><hash> where salt length can be 1-16 bytes and inferred from total length (note: no field delimiter). Raw ciphertext: The last of the ciphertext is always the SHA-1 hash and anything before that is the salt. 4 bytes salt defaults to 1 iteration (this is XSHA). Other salt lengths default to 1024 iterations. No salt still means 1024 iterations but you can force this format to do single raw sha1 using $sisha1$1$<hash> because, well, why not?
solardiz
approved these changes
Nov 19, 2025
Member
solardiz
left a comment
solardiz
left a comment
There was a problem hiding this comment.
Not a full review, but I skimmed.
Where are these hashes used? Why specifically 1024 iterations? Do we need default iteration counts at all, or should we require the field?
| int getdec(char *string, char separator) | ||
| { | ||
| int i = 0; | ||
| char buf[11]; |
Member
There was a problem hiding this comment.
I'd use const char * for the argument, and two pointers instead of i.
| int i = 0; | ||
| char buf[11]; | ||
|
|
||
| while (string[i] && string[i] >= '0' && string[i] <= '9') { |
Member
There was a problem hiding this comment.
No need to check string[i] for non-zero if we also do the range check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iterated-sha1 format(s). Optionally salted ($s.$p) and optionally iterated. Actually they can even do raw-sha1 if formatted right!