androidfde2john.py: Write warning to stderr, not stdout #5900
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solardiz
requested changes
Nov 19, 2025
Member
solardiz
left a comment
solardiz
left a comment
There was a problem hiding this comment.
I think we need to add \n to the string
Member
|
We have some more instances of |
magnumripper
force-pushed
the
stderr
branch
4 times, most recently
from
6dd324f to
5d7e494
Compare
Member
Author
Yes, many in that one. I'm not touching it as there's a PR affecting it. I can't find any others. |
Member
This finds some: fgrep -A1 stderr.write *.py | fgrep -v '\n' | grep -B1 '"[) ]' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.