Skip to content

Conversation

jeis4wpi
Copy link

Propose spelling fix

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fine.

@pstaabp
Copy link
Member

pstaabp commented Oct 7, 2025

@jeis4wpi In the future, name the branch that you want to merge in something different than develop. Generally, we like to test the code and having the branch called develop makes it more difficult. For example, I would call this branch fix-spelling or something similar.

@jeis4wpi
Copy link
Author

jeis4wpi commented Oct 7, 2025

Thank you for the advice @pstaabp

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the code formatting issue, this looks good.

@jeis4wpi
Copy link
Author

jeis4wpi commented Oct 8, 2025

is the close brace line 3231 the space issue ? macros/core/PGbasicmacros.pl ??

is the command below correct ?
perltidy -pro=./.perltidyrc macros/core/PGbasicmacros.pl

@drgrice1
Copy link
Member

drgrice1 commented Oct 8, 2025

That command will work. Note that you can also use the bin/run-perldity.pl script included in the repository. With that the command would be ./bin/run-perltidy.pl macros/core/PGbasicmacros.pl. That is assuming that you are in the /opt/webwork/pg directory. You can also just run ./bin/run-perltidy.pl without a file name, and it will run perltidy on all Perl files in the repository. That can take a bit though. One advantage of using the script is that it checks that you are using the version of perltidy that will work right to format the same way that the workflow does. It also adds some other options that are nice, such as the option that prevents perltidy from creating .bak files.

@drgrice1
Copy link
Member

drgrice1 commented Oct 8, 2025

is the close brace line 3231 the space issue ? macros/core/PGbasicmacros.pl ??

Yes, that is the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants