Update to Reaction context #1315
Open
+456
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion to molecular form, and allow comparisons based on molecular forms, better handling of charges
|
The following warning appears when running the MWE given in openwebwork/mathquill#41: Argument "type" isn't numeric in subtraction (-) at line 874 of [PG]/macros/contexts/contextReaction.pl Without sinking into the code, this warning can be suppressed if "$other -type" in line 874 is changed to "$other ->type". |
|
Thanks @sfiedle1, I'm not sure how that got messed up. I've added a commit to fix it. |
pstaabp
reviewed
Oct 7, 2025
| correct answer in the form the correct answer is given (molecular or | ||
| condensed structural form). If you want to allow either form, then | ||
| you can set the flag C<acceptMolecularForm> to C<1>, in which case, | ||
| the student's answwer is compared first to the original correct answer |
pstaabp
reviewed
Oct 7, 2025
| $R = Compute("CH_3CH_2CH_3")->molecularForm; | ||
| would make C<$R> be the quivalent of C<Compute("C_3H_8")>. |
drgrice1
reviewed
Oct 8, 2025
| you can set the flag C<acceptMolecularForm> to C<1>, in which case, | ||
| the student's answwer is compared first to the original correct answer | ||
| and then to its molecular form. For example, if the correct answer is | ||
| `(NH_4)_3PO_4`, then a student answer of `N_3H_12PO_4` would also be |
There was a problem hiding this comment.
It looks like you fell into markdown mode here! This should probably be
Suggested change
| `(NH_4)_3PO_4`, then a student answer of `N_3H_12PO_4` would also be | |
| C<(NH_4)_3PO_4>, then a student answer of C<N_3H_12PO_4> would also be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that includes a bunch of new features that I had in the wings but was waiting for some feedback from the folks I made the changes for (which never came). In light of openwebwork/mathquill#41, I thought I'd fix that problem, and include these other changes as well.
The changes here are to:
See the changes to the comments (in particular the new large section on molecular form). There are a bunch of new flags to control how the checking is performed.
The new section in the
Close()method of thecontext::Reactionpackage is the part that fixes the parentheses around charges.Some methods that are common to multiple objects have been moved into a new
context::Reaction::commonpackage, and there is new data stored about the elements in a compound that is used to manage the molecular form. Most of the rest is new methods used for computing the molecular forms.