Fix a bug with MathQuill options in the context flag before it is really an issue. #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Oct 31, 2025
…lly an issue. The current code passes on the option from the context as a hard coded zero instead of the actual option value from the context flag. This works at this point because this is only used by the parserLogb.pl macro to make MathQuill not use the base change formula and the option value it is passing is zero. However, in the future if a context ever wanted to enable a MathQuill feature then it wouldn't work.
drgrice1
force-pushed
the
bugfix/future-mq-opt-issue
branch
from
78756d3 to
1c052bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code passes on the option from the context as a hard coded zero instead of the actual option value from the context flag. This works at this point because this is only used by the parserLogb.pl macro to make MathQuill not use the base change formula and the option value it is passing is zero. However, in the future if a context ever wanted to enable a MathQuill feature then it wouldn't work.