Remove the STATIC_EXPIRES option. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Jun 27, 2025
The option is set up to set an expiration for static assets served from the `webwork2_files` route. However, there is no such route anymore for the renderer, and so the option currently does nothing. This could be adapted to work for the other files in public, but there is not point in that. The static assets used in production are either local assets that are minimized and served with a hash in the file name, or are third party assets and a version parameter is appended as a query parameter. As such, when files change the browser will get the new versions.
drgrice1
force-pushed
the
remove-static-expires
branch
from
f303cdc to
f3f56c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is set up to set an expiration for static assets served from the
webwork2_filesroute. However, there is no such route anymore for the renderer, and so the option currently does nothing. This could be adapted to work for the other files in public, but there is not point in that. The static assets used in production are either local assets that are minimized and served with a hash in the file name, or are third party assets and a version parameter is appended as a query parameter. As such, when files change the browser will get the new versions.