Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Print Console Errors when browser test fails #351

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

dee077
Copy link
Contributor

@dee077 dee077 commented Mar 21, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Closes #352

Description of Changes

  • Fix getPresentNodesAndLinksCount to fetch from the Basic usage example in the test render the Basic usage example without console errors
  • Print console error if they are found.

@dee077 dee077 force-pushed the console-error-logging branch from 0a2ff7c to fea62af Compare March 21, 2025 22:34
Copy link
Member

@devkapilbansal devkapilbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dee077
From this PR title, it looks like you are just adding logs. Here in the description it is mentioned that you are fixing. Kindly ensure that the title is informative.

Also, if this PR is for a fix, isn't there any issue open? If not, you can create one and link it to the PR

@dee077 dee077 changed the title [tests] Log Console Errors [tests] Print Console Errors when browser test fail Mar 22, 2025
@dee077 dee077 changed the title [tests] Print Console Errors when browser test fail [tests] Print Console Errors when browser test fails Mar 22, 2025
@dee077
Copy link
Contributor Author

dee077 commented Mar 22, 2025

Created an issue and changed the title of this PR

@nemesifier
Copy link
Member

nemesifier commented Mar 24, 2025

@devkapilbansal this PR is a follow up of previous changes and I've been discussing it with @dee077. In these cases creating an issue is not such an important necessity but you are super right in pointing out that we need to be clear when communicating, not only in making sure the title and description of the PR is clear but also state that the need of these changes came up during previous discussions. We can also link the previous issue or PR that this PR is related to. That's totally fine.

This PR is a follow up of #269.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dee077 👍

@nemesifier nemesifier merged commit b9eaa77 into openwisp:master Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tests] Print console error when browser test fail
3 participants