Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic improvements to EGL-19 parameter fitting script #19

Open
gsarma opened this issue Sep 12, 2018 · 1 comment
Open

Generic improvements to EGL-19 parameter fitting script #19

gsarma opened this issue Sep 12, 2018 · 1 comment
Assignees

Comments

@gsarma
Copy link
Member

gsarma commented Sep 12, 2018

  1. For some reason, the way I've implemented the dynamic updating of the simulation trajectory, after the run is complete, it outputs the entire trajectory frame by frame (you can see this in the notebook). This needs to be fixed.

  2. Adding a small function to generate many runs of the simulation and plot histograms of the parameters so that we can visualize the robustness of simulation results (see the pinned plot in the Slack channel).

  3. Any other generic Python improvements would be appreciated.

@travs

@gsarma gsarma added this to the Parameter Fitting milestone Sep 12, 2018
travs added a commit to travs/ChannelWorm2 that referenced this issue Sep 16, 2018
travs added a commit to travs/ChannelWorm2 that referenced this issue Sep 16, 2018
@travs
Copy link

travs commented Sep 16, 2018

Ok so have fixed points 1 and 2.
For 2, the distribution histograms retain outliers so the plots may look "zoomed out". We can adjust this if we wish, but they still show that the distributions are very tight.

For the notebooks, it might be helpful if we establish the convention of removing output cells as we develop a notebook. These cells don't play well with version control, because they are generated and binary, so it makes diffs harder to understand, and bloats the repo in the long term.
For now we can use Cell -> All output -> Clear in the notebook interface before we commit.

If this gets annoying and we want to automate it we can look at these solutions or these tips.

@travs travs closed this as completed Sep 16, 2018
@travs travs reopened this Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants