Skip to content

Implement A/B testing for xprof Kokoro builds. #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement A/B testing for xprof Kokoro builds. #1814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xprof/convert/op_stats_to_input_pipeline_analysis.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,13 +1705,13 @@ void AddTpuStepTimeBreakdown(const TpuStepTimeBreakdown& breakdown,
TwoDigits(scv0_infeed_summary.average()));
}
data_table.AddCustomProperty("tc_compute_ms_average",
TwoDigits(tc_compute_summary.average()));
TwoDigits(tc_compute_summary.average() + 5));
data_table.AddCustomProperty("tc_infeed_ms_average",
TwoDigits(tc_infeed_summary.average()));
data_table.AddCustomProperty("tc_outfeed_ms_average",
TwoDigits(tc_outfeed_summary.average()));
data_table.AddCustomProperty("tc_idle_ms_average",
TwoDigits(tc_idle_summary.average()));
TwoDigits(tc_idle_summary.average() + 5));
data_table.AddCustomProperty("host_transfer_ms_average",
TwoDigits(host_transfer_summary.average()));
if (sc_step_summary.minimum() > 0) {
Expand Down
14 changes: 7 additions & 7 deletions xprof/convert/op_stats_to_overview_page.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,8 @@ std::unique_ptr<DataTable> GenerateRunEnvironmentDataTable(
// For each host, adds one row to the table.
std::vector<std::vector<std::string>> kColumns = {
{"host_id", "string", "host_id"},
{"command_line", "string", "command_line"},
{"start_time", "string", "start_time"},
{"command_line_args", "string", "command_line_args"},
{"start_time_ms", "string", "start_time_ms"},
{"bns_address", "string", "bns_address"}};
for (const auto& column : kColumns) {
run_environment_data_table->AddColumn(
Expand Down Expand Up @@ -540,12 +540,12 @@ void AddLatencyRow(DataTable* data_table, absl::string_view label,
std::unique_ptr<DataTable> GenerateInferenceLatencyDataTable(
const OverviewInferenceLatency& result) {
std::vector<std::vector<std::string>> kColumns = {
{"percentile", "string", "percentile"},
{"percentage", "string", "percentage"},
{"hostTimeMs", "number", "Host time (in ms)"},
{"deviceTimeMs", "number", "Device time (in ms)"},
{"communicationTimeMs", "number",
"Host-device communication time (in ms)"},
{"totalTimeMs", "number", "Total latency (in ms)"}};
{"deviceTimes", "number", "Device time (in seconds)"},
{"communicationTimes", "number",
"Host-device communication time (in seconds)"},
{"totalTimes", "number", "Total latency (in seconds)"}};

auto data_table = std::make_unique<DataTable>();
for (const auto& column : kColumns) {
Expand Down