Update protobuf dependency version #1857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our protos get built and compiled with `gencode 6.31.1`, and protobuf does not have compatibility outside of major versions. This also resolves an issue with using a protobuf API from a newer version. This will cause an incompatibility with Tensorflow<=2.20. This incompatibility is already technically there, but invisible. Tensorflow==2.19.X has a hard-cap on the protobuf version, preventing it from using 6.X.X. Unfortunately, XLA depends on 6.X.X protos, so this change is required. Resolves #1846 PiperOrigin-RevId: 821721239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update protobuf dependency version
Our protos get built and compiled with
gencode 6.31.1, and protobuf does not have compatibility outside of major versions. This also resolves an issue with using a protobuf API from a newer version.This will cause an incompatibility with Tensorflow<=2.20. This incompatibility is already technically there, but invisible. Tensorflow==2.19.X has a hard-cap on the protobuf version, preventing it from using 6.X.X. Unfortunately, XLA depends on 6.X.X protos, so this change is required.
Resolves #1846