Remove libtpool #17948
Open
Remove libtpool #17948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing it this way means that callers don't have to call system_taskq_init() and also get the system and system_delay taskqs that they possibly don't even want. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>
They're basically the same thing; lets just carry one. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>
robn
force-pushed
the
libtpool-delete
branch
from
c524df8 to
e32d660
Compare
amotin
approved these changes
Nov 18, 2025
behlendorf
approved these changes
Nov 18, 2025
behlendorf
added
Status: Accepted
ikozhukhov
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Looking into the literature on task queueing and scheduling, I discovered that "thread pool" and "task queue" are basically the same thing. As a consummate professional, I naturally said "wuh?", and had a look at our own
libtpool. Sure enough, almost the same interface. To hide my shame, I have elected to remove it entirely, and perhaps no one will ever know.No but seriously, its a bit like
libuutil(#17934) - the same as a thing we use everywhere else. Lets not carry two when one will do.Description
Just the two commits. First, a small adjustment to libspl/taskq so it is self-initialising. Then, converting all the
tpool_tusers totaskq_t.How Has This Been Tested?
Compile checked on Linux & FreeBSD, full ZTS pass on Linux.
Types of changes
Checklist:
Signed-off-by.