Skip to content

Fixes #146: write -> check in CI QA#147

Merged
benoit74 merged 1 commit intoopenzim:mainfrom
aaryansinhaa:prettier-check-in-qa
Apr 2, 2026
Merged

Fixes #146: write -> check in CI QA#147
benoit74 merged 1 commit intoopenzim:mainfrom
aaryansinhaa:prettier-check-in-qa

Conversation

@aaryansinhaa
Copy link
Copy Markdown
Contributor

Fixes #146
changes write to check, similarly for eslint.

@aaryansinhaa
Copy link
Copy Markdown
Contributor Author

@benoit74 PTAL

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.33%. Comparing base (a2eae2f) to head (ca49a53).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          11       11           
  Lines         477      477           
  Branches       92       92           
=======================================
  Hits          159      159           
  Misses        313      313           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you have to fix prettier (and maybe eslint) issues in this same PR.

@aaryansinhaa aaryansinhaa force-pushed the prettier-check-in-qa branch from 2113729 to ca49a53 Compare April 1, 2026 02:57
@aaryansinhaa
Copy link
Copy Markdown
Contributor Author

@benoit74 good to go

@aaryansinhaa aaryansinhaa requested a review from benoit74 April 1, 2026 03:06
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Would you mind to open issues in other scrapers to fix that as well? (TbC, but maps, mindtouch, gutenberg and youtube probably all suffer the same flaw since we mostly copy-pasted the pattern)

@benoit74 benoit74 merged commit 7f59946 into openzim:main Apr 2, 2026
10 checks passed
@aaryansinhaa
Copy link
Copy Markdown
Contributor Author

Sure, this is a small fix, I'll do it, thanks

@aaryansinhaa aaryansinhaa deleted the prettier-check-in-qa branch April 2, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI passes even if formating is bad

2 participants