Fixes #146: write -> check in CI QA#147
Merged
benoit74 merged 1 commit intoopenzim:mainfrom Apr 2, 2026
Merged
Conversation
Contributor
Author
|
@benoit74 PTAL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 11 11
Lines 477 477
Branches 92 92
=======================================
Hits 159 159
Misses 313 313
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benoit74
requested changes
Mar 31, 2026
Collaborator
benoit74
left a comment
There was a problem hiding this comment.
Now you have to fix prettier (and maybe eslint) issues in this same PR.
2113729 to
ca49a53
Compare
Contributor
Author
|
@benoit74 good to go |
benoit74
approved these changes
Apr 2, 2026
Collaborator
benoit74
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Would you mind to open issues in other scrapers to fix that as well? (TbC, but maps, mindtouch, gutenberg and youtube probably all suffer the same flaw since we mostly copy-pasted the pattern)
Contributor
Author
|
Sure, this is a small fix, I'll do it, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146
changes write to check, similarly for eslint.