resolves #146: Fixes zimui qa prettier and linter check#147
Merged
benoit74 merged 1 commit intoopenzim:mainfrom Apr 22, 2026
Merged
resolves #146: Fixes zimui qa prettier and linter check#147benoit74 merged 1 commit intoopenzim:mainfrom
benoit74 merged 1 commit intoopenzim:mainfrom
Conversation
9db37b5 to
1769f77
Compare
Contributor
Author
There was a problem hiding this comment.
Pull request overview
This PR addresses the ZimUI QA CI failures by aligning code formatting with Prettier/ESLint expectations and separating “check” vs “fix” scripts so CI can validate without mutating files.
Changes:
- Reformats multiple ZimUI TS/Vue/config files to satisfy Prettier/ESLint (commas, wrapping, spacing, indentation).
- Updates
zimui/package.jsonto addlint-check/format-checkscripts and makeslintrun with--fix. - Updates GitHub QA workflow to run non-mutating formatter/linter checks for ZimUI.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
zimui/vite.config.ts |
Prettier-aligned object formatting. |
zimui/src/types/TopicCardData.ts |
Prettier-aligned TS formatting (params/object literals). |
zimui/src/stores/main.ts |
Prettier-aligned Pinia store formatting. |
zimui/src/routes.ts |
Removes trailing comma to match Prettier config. |
zimui/src/main.ts |
Prettier-aligned router config formatting. |
zimui/src/components/TopicSection.vue |
Prettier-driven template/script/style formatting and spacing fixes. |
zimui/src/components/TopicHome.vue |
Prettier-driven template/script/style formatting. |
zimui/src/components/TopicCard.vue |
Prettier-driven template/script formatting. |
zimui/src/components/ToolBar.vue |
Prettier-driven script/template formatting. |
zimui/src/components/TagButton.vue |
Prettier-driven script formatting. |
zimui/src/components/ErrorDisplay.vue |
Removes stray whitespace/blank line in style block. |
zimui/src/App.vue |
Prettier-driven CSS @font-face formatting. |
zimui/postcss.config.js |
Prettier-aligned config formatting. |
zimui/package.json |
Adds check scripts; adjusts lint to --fix. |
zimui/index.html |
Normalizes doctype casing. |
zimui/eslint.config.mjs |
Prettier-aligned ignore list formatting. |
zimui/.prettierrc.json |
Normalizes EOF newline/formatting. |
CHANGELOG.md |
Adds entry for #146 and normalizes formatting. |
.github/workflows/QA.yml |
Switches ZimUI QA steps to format-check / lint-check. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Oh I just saw Copilot remark which is valid. Please fix before I merge |
8a44039 to
756b27d
Compare
Contributor
Author
|
@benoit74 done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes zimui QA issue