Skip to content

resolves #146: Fixes zimui qa prettier and linter check#147

Merged
benoit74 merged 1 commit intoopenzim:mainfrom
aaryansinhaa:bugfix/CI-issue
Apr 22, 2026
Merged

resolves #146: Fixes zimui qa prettier and linter check#147
benoit74 merged 1 commit intoopenzim:mainfrom
aaryansinhaa:bugfix/CI-issue

Conversation

@aaryansinhaa
Copy link
Copy Markdown
Contributor

Fixes zimui QA issue

@aaryansinhaa aaryansinhaa changed the title resolves #146 resolves #146: Fixes zimui qa prettier and linter check Apr 14, 2026
@aaryansinhaa
Copy link
Copy Markdown
Contributor Author

@kelson42 @benoit74 can you please review this PR. thanks!

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the ZimUI QA CI failures by aligning code formatting with Prettier/ESLint expectations and separating “check” vs “fix” scripts so CI can validate without mutating files.

Changes:

  • Reformats multiple ZimUI TS/Vue/config files to satisfy Prettier/ESLint (commas, wrapping, spacing, indentation).
  • Updates zimui/package.json to add lint-check / format-check scripts and makes lint run with --fix.
  • Updates GitHub QA workflow to run non-mutating formatter/linter checks for ZimUI.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
zimui/vite.config.ts Prettier-aligned object formatting.
zimui/src/types/TopicCardData.ts Prettier-aligned TS formatting (params/object literals).
zimui/src/stores/main.ts Prettier-aligned Pinia store formatting.
zimui/src/routes.ts Removes trailing comma to match Prettier config.
zimui/src/main.ts Prettier-aligned router config formatting.
zimui/src/components/TopicSection.vue Prettier-driven template/script/style formatting and spacing fixes.
zimui/src/components/TopicHome.vue Prettier-driven template/script/style formatting.
zimui/src/components/TopicCard.vue Prettier-driven template/script formatting.
zimui/src/components/ToolBar.vue Prettier-driven script/template formatting.
zimui/src/components/TagButton.vue Prettier-driven script formatting.
zimui/src/components/ErrorDisplay.vue Removes stray whitespace/blank line in style block.
zimui/src/App.vue Prettier-driven CSS @font-face formatting.
zimui/postcss.config.js Prettier-aligned config formatting.
zimui/package.json Adds check scripts; adjusts lint to --fix.
zimui/index.html Normalizes doctype casing.
zimui/eslint.config.mjs Prettier-aligned ignore list formatting.
zimui/.prettierrc.json Normalizes EOF newline/formatting.
CHANGELOG.md Adds entry for #146 and normalizes formatting.
.github/workflows/QA.yml Switches ZimUI QA steps to format-check / lint-check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@benoit74
Copy link
Copy Markdown
Collaborator

Oh I just saw Copilot remark which is valid. Please fix before I merge

@aaryansinhaa
Copy link
Copy Markdown
Contributor Author

@benoit74 done!

Copy link
Copy Markdown
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@benoit74 benoit74 merged commit 505d954 into openzim:main Apr 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants