improve: ResourceIDMapper and ResourceIDProvider for external resources #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-merge-robot
added
the
needs-rebase
csviri
force-pushed
the
resource-id-mapper
branch
from
f45940d to
658563b
Compare
openshift-merge-robot
removed
the
needs-rebase
csviri
changed the title
csviri
changed the title
…pper Signed-off-by: Attila Mészáros <[email protected]>
Will check if this could be elegantly extended to bulk resources Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
resource-id-mapper
branch
from
63cfeb0 to
f615a86
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
created a variant that covers also bulk dependents, that looks very reasonable: I would prefer to go with that version. |
|
Should that branch be deleted then? |
xstefank
reviewed
Oct 27, 2025
| * Provides the identifier for an object that represents an external resource. This ID is used to | ||
| * select target resource for a dependent resource from the resources returned by `{@link | ||
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. | ||
| * Provides the identifier for an object that represents resource. This ID is used to select target |
There was a problem hiding this comment.
Suggested change
| * Provides the identifier for an object that represents resource. This ID is used to select target | |
| * Provides the identifier for an object that represents a resource. This ID is used to select the target |
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. | ||
| * Provides the identifier for an object that represents resource. This ID is used to select target | ||
| * external resource for a dependent resource from the resources returned by `{@link | ||
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. But also for |
There was a problem hiding this comment.
Suggested change
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. But also for | |
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. Is is also used as |
| * Provides the identifier for an object that represents resource. This ID is used to select target | ||
| * external resource for a dependent resource from the resources returned by `{@link | ||
| * io.javaoperatorsdk.operator.api.reconciler.Context#getSecondaryResources(Class)}`. But also for | ||
| * {@link ResourceIDMapper} for event sources in external resources |
There was a problem hiding this comment.
Suggested change
| * {@link ResourceIDMapper} for event sources in external resources | |
| * {@link ResourceIDMapper} for event sources in external resources. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: