possible refinements

[shawkins]

A few ideas for simplifying the logic.

[shawkins]

I don't think we can generally guarentee that the resource versions will fall in the int range.

[shawkins]

@csviri can you explain why this allows for equality?

[csviri]

Since we can remove the resource in that case from the cache.

[shawkins]

Right, so this needs refined a little further - it should remove, but still be seen as a known event.

[csviri]

Note that in the implementation we strictly define two cases: when we want to filter the event and when we don't, based on user's intention.
So there is no grey area now.

[shawkins]

The wording may be confusing across a couple of methods.

The boolean used to mean "known event" - so if I put a version into the temporary resource cache, then see the event with the same version, it's a known event.

Does "filter event" have a subtely different meaning from "known event"?

[csviri]

Hmm good question, the filter event mean to express that the event won't be propagated further (if true). This is bit more descriptive since we might actually not know all the events (watch connection issues).