-
Notifications
You must be signed in to change notification settings - Fork 43
[WIP] olmv1 catalog search #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Rashmi Gottipati <[email protected]>
Signed-off-by: Ankita Thomas <[email protected]>
return resp.Body, nil | ||
} | ||
|
||
func NewK8sClient(cfg *rest.Config, cl client.Client) Client { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be reasonably assured this access will stay safe from the NetworkPolicy work we're also working on? I guess this counts as ingress? IIRC all egress is open initially but maybe not all ingress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt this will be unaffected by the NetworkPolicy changes in progress. I plan to hold off on this and revisit it next sprint with the added context.
@ankitathomas or @rashmigottipati looks like the |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Search catalog contents.
--list-versions
allows listing multiple versions from one or more package.