Skip to content

🐛 Clear cert warning during deployments #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Jul 23, 2025

This removes the following warning by explicitly setting the value to the default:

Warning: spec.privateKey.rotationPolicy: In cert-manager >= v1.18.0, the default value changed from `Never` to `Always`.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

This removes the following warning by explicitly setting the value
to the default:

```
Warning: spec.privateKey.rotationPolicy: In cert-manager >= v1.18.0, the default value changed from `Never` to `Always`.
```

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner July 23, 2025 13:58
Copy link

netlify bot commented Jul 23, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3ccfab6
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6880ea9f2aaf0b0008ec9402
😎 Deploy Preview https://deploy-preview-2114--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.65%. Comparing base (8cf5bda) to head (3ccfab6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2114      +/-   ##
==========================================
+ Coverage   72.61%   73.65%   +1.03%     
==========================================
  Files          78       78              
  Lines        7260     7260              
==========================================
+ Hits         5272     5347      +75     
+ Misses       1633     1564      -69     
+ Partials      355      349       -6     
Flag Coverage Δ
e2e 43.55% <ø> (ø)
experimental-e2e 56.21% <ø> (?)
unit 58.88% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
Copy link

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4d66a2c into operator-framework:main Jul 24, 2025
22 checks passed
@tmshort tmshort deleted the fix-warning branch July 24, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants