Repository navigation
[SE-695] Offer user mentions in forum messages [Passion Time] - #141
Merged
Merged
Conversation
Contributor
dfriquet
force-pushed
the
se-695-mentions-for-any-resource
branch
from
October 15, 2026 07:24
100046f to
3529c5c
Compare
7 of 8 tasks
Contributor
Author
oliverguenther
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PR
Ticket
https://community.openproject.org/wp/SE-695
What are you trying to accomplish?
Typing
@in a forum message's editor should suggest users to mention, as it does in work package comments. Today the user-mention feed returns no suggestions unless the editor's resource is a work package, so forum editors never suggest anyone.What approach did you choose and why?
The feed no longer checks the resource type itself. It asks
pathHelper.api.v3.principals(resource, term)for a URL and offers no suggestions when that returns none. OpenProject now decides where users can be mentioned: work packages as before, forum messages (members of the message's project), and nowhere else. A new resource type can get mentions without another editor build.The feed still unwraps
Activity::Commentand still honoursdisabledMentions. The fetch, deduplication and item mapping are unchanged, and the#,##,###and:feeds are untouched. An OpenProject without the newprincipals()keeps working: that version always returns a URL, and the feed only reaches it for work packages, as before.Merge checklist