Skip to content

[SE-695] Offer user mentions in forum messages [Passion Time] - #141

Merged
dfriquet merged 1 commit into
masterfrom
se-695-mentions-for-any-resource
Oct 16, 2026
Merged

dfriquet merged 1 commit into
masterfrom
se-695-mentions-for-any-resource

Conversation

@dfriquet

@dfriquet dfriquet commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Related PR

Ticket

https://community.openproject.org/wp/SE-695

What are you trying to accomplish?

Typing @ in a forum message's editor should suggest users to mention, as it does in work package comments. Today the user-mention feed returns no suggestions unless the editor's resource is a work package, so forum editors never suggest anyone.

What approach did you choose and why?

The feed no longer checks the resource type itself. It asks pathHelper.api.v3.principals(resource, term) for a URL and offers no suggestions when that returns none. OpenProject now decides where users can be mentioned: work packages as before, forum messages (members of the message's project), and nowhere else. A new resource type can get mentions without another editor build.

The feed still unwraps Activity::Comment and still honours disabledMentions. The fetch, deduplication and item mapping are unchanged, and the #, ##, ### and : feeds are untouched. An OpenProject without the new principals() keeps working: that version always returns a URL, and the feed only reaches it for work packages, as before.

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc

myabc commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

unfortunately this will now needs some changes (i,e, migration to TS). apologies for the breakage due to #135, #136, #137. Ping me if you need a hand!

@dfriquet
dfriquet force-pushed the se-695-mentions-for-any-resource branch from 100046f to 3529c5c Compare October 15, 2026 07:24
@dfriquet

Copy link
Copy Markdown
Contributor Author

unfortunately this will now needs some changes (i,e, migration to TS). apologies for the breakage due to #135, #136, #137. Ping me if you need a hand!

Migrated to TS 👌

@dfriquet dfriquet changed the title [Passion Time] [SE-695] Offer user mentions in forum messages [SE-695] Offer user mentions in forum messages [Passion Time] Oct 16, 2026
@dfriquet
dfriquet merged commit 83a9f79 into master Oct 16, 2026
4 checks passed
@dfriquet
dfriquet deleted the se-695-mentions-for-any-resource branch October 16, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants