Repository navigation
Conversation
Takes the build that esbuild produces instead of webpack. The editor sources are unchanged, as are the stylesheet and the translations. Runs the suite against the new bundle before the editor moves from this vendored copy to an npm dependency. https://community.openproject.org/wp/OP-20422
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/OP-20422
What are you trying to accomplish?
Updates the vendored CKEditor build to the one produced by opf/commonmark-ckeditor-build#139, which bundles the editor with esbuild instead of webpack. The editor sources are unchanged; only
ckeditor.jsand its source map differ. The stylesheet and the translations are byte-identical.This PR exists to run the full suite against the new bundle before the way the editor is delivered changes. It is the last time build output is copied into this repository for OP-20422: a follow-up replaces
frontend/src/vendor/ckeditor/with a pinned npm dependency.What approach did you choose and why?
The bundle is now an ES module instead of UMD. It still assigns
window.OPClassicEditor,window.OPConstrainedEditorandwindow.OPEditorWatchdog, which is all the editor setup service reads, so nothing else changes here. It is 3.5% larger before compression (1,455,370 bytes against 1,405,787).Changing the bundler and changing the delivery in one step would leave two possible causes for any failure. Testing the bundle alone first keeps them apart.
AI involvement
Merge checklist