Merge stable into develop#1177
Merged
Merged
Conversation
) ## feat(ctl): add marketplace --dependencies flag with server-side resolution Add `--dependencies` flag to `marketplace get` for collections and schemas, recursively downloading transitive dependencies resolved server-side via new `/dependencies` endpoints. ### Key features - **Collections:** prerequisite collections grouped into subdirectories, members and standalone schemas in output root - **Schemas:** dependencies grouped by owning collection (or root if standalone) - **Soft-fail** for unresolved/missing schema dependencies; strict for collection members - **Deduplication, cycle safety,** and reconciliation with existing schemas (keep by default, overwrite with `-y`) - **Path validation** (`_safe_segment`) to prevent directory traversal attacks - **Versioned** schema downloads resolve the pinned version's dependencies ### Technical changes - Replaced client-side dependency walk with single server-side `/dependencies` endpoint call - Report visibility-hidden dependencies in summary **Refs:** IHS-246, #1117
github-actions
Bot
added
the
type/documentation
Deploying infrahub-sdk-python with
|
| Latest commit: |
81612ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04a677c9.infrahub-sdk-python.pages.dev |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## develop #1177 +/- ##
===========================================
+ Coverage 82.88% 82.97% +0.09%
===========================================
Files 139 139
Lines 13074 13218 +144
Branches 2069 2097 +28
===========================================
+ Hits 10836 10968 +132
- Misses 1627 1633 +6
- Partials 611 617 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
polmichel
reviewed
Jul 13, 2026
| @@ -0,0 +1 @@ | |||
| Added a `--dependencies` flag to `infrahubctl marketplace get`. When downloading a schema or a collection, it now also resolves and downloads the schemas they depend on, via the marketplace API. Dependencies are grouped by the collection they belong to: prerequisite collections (and, for a single schema, dependencies that are members of a collection) are placed in their own `<collection>/` directory, while dependencies that belong to no collection land in the output root. Referenced kinds the marketplace cannot resolve are reported as unresolved dependencies. A schema that already exists in the output directory is reconciled to a single file rather than duplicated across directories — kept by default, or overwritten with the new `-y`/`--yes` flag. | |||
Contributor
There was a problem hiding this comment.
This changelog is quite long, is this something we really want in a release note @minitriga?
You can take a look at the guidelines in infrahub project related to changelogs (infrahub/dev/guidelines/changelog.md), or the new skill @saltas888 is working on opsmill/infrahub#9663.
I think we need to copy the changelog file into the infrahub-sdk project aswell.
Contributor
There was a problem hiding this comment.
And has the initial PR been approved? #1118
My UI may have an issue, got a poor connection today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1118.
Summary by cubic
Adds
--dependenciestoinfrahubctl marketplace getto resolve and download transitive dependencies via the marketplace API, and-y/--yesto overwrite existing schemas when reconciling files. Aligns with IHS-246 by moving dependency resolution server-side and organizing outputs clearly.--dependencies: resolves full transitive deps server-side and downloads them.<requested>/; prerequisite collections under their own<collection>/; standalone deps at the output root. In schema mode, deps are grouped by owning collection (or root if none).-y/--yes(non-tty without--yesnever overwrites).Written for commit 81612ea. Summary will update on new commits.