restrict diff field summaries to the single diff being queried - #10054
Merged
Conversation
update the cypher query for get_node_field_summaries() to only check objects that are part of the diff instead of erroneously including objects with the same UUID from different diffs
github-actions
Bot
added
the
group/backend
ajtmccarty
commented
Jul 27, 2026
| retrieved_map = {summary.kind: summary for summary in retrieved_node_field_summaries} | ||
| assert expected_map == retrieved_map | ||
|
|
||
| async def test_get_node_field_summaries_excludes_other_diffs( |
Contributor
Author
There was a problem hiding this comment.
this is the actual new test
| WITH DISTINCT n.kind AS kind | ||
| CALL (kind) { | ||
| OPTIONAL MATCH (n:DiffNode {kind: kind})-[:DIFF_HAS_ATTRIBUTE]->(a:DiffAttribute) | ||
| WITH DISTINCT diff_root, n.kind AS kind |
Contributor
Author
There was a problem hiding this comment.
as you can see, we were not passing the diff_root into the subquery to anchor it to the correct diff
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This is a focused bug fix that restricts Cypher subqueries to the current diff root, preventing cross-diff field name leakage. The patch is bounded and clearly beneficial; a dedicated test validates the corrected behavior.
Re-trigger cubic
ogenstad
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the cypher query for get_node_field_summaries() to only check objects that are part of the diff instead of erroneously including objects with the same UUID from different diffs