test(scale): remove broken branch.diff_data call - #10144
Merged
Merged
Conversation
client.branch.diff_data() targets GET /api/diff/data which no longer exists, so the diff stager loop has been getting 404s. Use the GraphQL-based get_diff_tree() instead, which also goes through the instrumented execute_graphql so locust records the request. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
the
group/backend
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes a broken scale test call by switching from a removed REST endpoint to an existing GraphQL method, confined to test infrastructure with no production impact.
Re-trigger cubic
This was referenced Aug 6, 2026
gmazoyer
approved these changes
Aug 7, 2026
The SDK is deleting the broken branch.diff_data() without a replacement, so the scale test no longer polls the diff during the loop. The closing branch merge still exercises the server-side diff at scale. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
saltas888
changed the title
Contributor
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. This removes a dead diff_data() call from a scale-test stager loop; the endpoint and SDK method are gone, so the call was a no-op 404 that never measured anything. Test-infrastructure only, no production behavior changes.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The scale test's diff stager loop calls
client.branch.diff_data("DiffTestBranch"), but that SDK method targetsGET /api/diff/data, an endpoint removed in #4865, so every call has been silently returning a 404 instead of exercising the diff feature.This is part of the rework of #8594 as suggested by @ogenstad: the broken
diff_data()method is deleted from the SDK without a replacement, nobody can have been using it (opsmill/infrahub-sdk-python#1229).What changed
backend/tests/scale/common/users.py: the diff fetch is removed from the stager loop. It never measured anything (404 since the endpoint was removed), and withdiff_data()gone from the SDK there is nothing to call. The closingbranch.merge("DiffTestBranch")stays, so the diff stager still exercises the server-side diff/merge path at scale.No changelog entry, test-infrastructure only.
How to review
The stager loop in the scale test loses its dead diff call, nothing else changes.
Impact & rollout