refactor(agents): remove git-pr command in favor of the pr skill#9966
Open
saltas888 wants to merge 2 commits into
Open
refactor(agents): remove git-pr command in favor of the pr skill#9966saltas888 wants to merge 2 commits into
saltas888 wants to merge 2 commits into
Conversation
saltas888
added
type/housekeeping
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Confidence score: 5/5
- Safe to merge after the addressed issues were fixed.
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
The `/git-pr` command duplicated the PR-creation flow the `pr` skill already owns (push, description, gh pr create). Remove it and rewire its only consumer, the feature-flow skill, to delegate PR opening to `/pr` — mirroring how feature-flow already delegates committing to `/git-commit`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…tion Address review feedback on the git-pr → /pr rewire. `/pr` (without `commit`) does not push, only warns on a dirty tree, and cannot force a base branch — guards the old `/git-pr` provided. Restore them in the orchestrator without reimplementing PR creation: - STOP on a dirty working tree before invoking /pr (was: warn-and-continue). - Publish the branch (git push -u) before /pr, so gh pr create can't stall. - For dependent split PRs, retarget the base with gh pr edit and verify the diff, since /pr selects the repo default base itself. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
saltas888
force-pushed
the
chore/remove-git-pr-command
branch
from
July 20, 2026 08:31
cdcf34d to
798dcf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
git-prduplicated the PR-creation flow theprskill already owns (push, description,gh pr create). Two commands doing the same job is a maintenance trap and a source of drift.Goal: a single canonical PR path. Non-goal: changing how PRs get opened — the behaviour is preserved through the
prskill.What changed
/git-prslash command.feature-flowskill (Phase 6c), to delegate PR opening to/pr— mirroring how it already delegates committing to/git-commit, in line with feature-flow's own "reuse, don't reimplement" principle.No product code touched — this is
.agents/tooling and a dev-skill doc only.How to review
.agents/commands/git-pr.md— deleted.dev/skills/feature-flow/SKILL.md— Phase 6c now invokes/pr; the intro reuse-list swaps/git-pr→/pr.How to test
git grep git-pr # → no matches in tracked filesSummary by cubic
Removed the
/git-prcommand and routed all PR creation through/pr.feature-flownow enforces the old safety checks so behavior matches the previous flow.Refactors
.agents/commands/git-pr.md.dev/skills/feature-flow/SKILL.mdPhase 6c to delegate to/prand enforce: hard-stop on a dirty tree, push branch before calling, and for dependent split PRs retarget base after opening and add aDepends on #<parent-PR>line.Migration
/git-prusage with/pr.Written for commit 798dcf8. Summary will update on new commits.