docs: fix release-notes frontmatter from cubic review#9982
Merged
Conversation
Addresses the cubic review on #9978: - Correct env-var / parameter names missing underscores in release descriptions: 1.1.2 INFRAHUB_PUBLIC_URL; 1.2.1 and 1.2.9 INFRAHUB_SCHEMA_STRICT_MODE / INFRAHUB_TESTING_SCHEMA_STRICT_MODE; 1.3.1 min_value/max_value/excluded_values. - Fix description typos: 1.1.6 "cop" -> "copy"; 1.4.3 missing sentence break; 1.3.3 drop the leaked "<!-- vale off -->" directive. - 1.5.0: replace the generic placeholder description (identical to 1.4.0's) with a release-specific summary. - 1.8.0: correct release_date to 2026-03-16 to match the infrahub-v1.8.0 tag, in both frontmatter and the body table. 1.8.1 (2026-03-19) was already correct and is left unchanged; cubic's suggestion to change 1.8.1 was based on the wrong 1.8.0 date. - backfill-release-frontmatter.mjs: make --check fail on files with no frontmatter block, and serialize descriptions via JSON.stringify so backslashes/quotes stay valid YAML. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 10 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes frontmatter typos and env-var names in release notes, corrects a release date, and hardens a validation script. All changes are bounded and clearly beneficial.
Re-trigger cubic
fatih-acar
marked this pull request as ready for review
July 21, 2026 06:34
fatih-acar
enabled auto-merge (rebase)
July 21, 2026 06:34
polmichel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the cubic review on #9978 — the release-notes
descriptionfrontmatter that the backfill drafted (added onstable) had several content errors, plus two robustness gaps in the backfill script. Fixing at the source (stable) so the corrections propagate todevelopon the next sync.Frontmatter description fixes
release-1_1_2.mdxINFRAHUBPUBLICURL→INFRAHUB_PUBLIC_URLrelease-1_1_6.mdxcop→copyrelease-1_2_1.mdxINFRAHUBSCHEMASTRICTMODE→INFRAHUB_SCHEMA_STRICT_MODErelease-1_2_9.mdxINFRAHUBTESTINGSCHEMASTRICTMODE/INFRAHUBSCHEMASTRICTMODE→ underscored namesrelease-1_3_1.mdxminvalue/maxvalue/excludedvalues→min_value/max_value/excluded_valuesrelease-1_3_3.mdx<!-- vale off -->directive from the descriptionrelease-1_4_3.mdxhealthy. In the UI)release-1_5_0.mdxRelease-date correction (1.8.0)
release-1_8_0.mdx:release_datecorrected to 2026-03-16 (frontmatter + body table), matching theinfrahub-v1.8.0git tag. It was recorded as 2026-03-22.infrahub-v1.8.1). cubic flagged 1.8.1 as chronologically impossible, but that was a consequence of the wrong 1.8.0 date — with 1.8.0 corrected to 03-16, the 1.8.0 → 1.8.1 → 1.8.2 (03-25) order is consistent.Backfill script (
backfill-release-frontmatter.mjs)--checknow fails on files with no frontmatter block (previously skipped with a warning, so CI could pass on the most incomplete files).JSON.stringifyso backslashes/quotes stay valid YAML (the old quoted interpolation only escaped").Validation
node scripts/backfill-release-frontmatter.mjs --check— passes.node --checkon the script passes.🤖 Generated with Claude Code
Summary by cubic
Fixes frontmatter errors in release notes and corrects the 1.8.0 release date. Hardens the backfill script to fail on missing frontmatter and output YAML-safe descriptions.
docs/scripts/backfill-release-frontmatter.mjs:--checknow fails on files without frontmatter; descriptions useJSON.stringifyfor YAML-safe escaping.Written for commit 6f02322. Summary will update on new commits.