Skip to content

[FSSDK-11492] make public promise rejection messages non tree-shakable #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 5, 2025
Merged

[FSSDK-11492] make public promise rejection messages non tree-shakable #1041

merged 5 commits into from
May 5, 2025

Conversation

raju-opti
Copy link
Contributor

Summary

  • The mechanism in place for errorNotifier ensures that error messages used with OptimizelyError get tree-shaken if errorNotifier is not used. But some promise rejection errors are part of the public api and those messages must not be tree shake. This PR makes those message non tree-shakable.

Test plan

Issues

  • FSSDK-11492

@coveralls
Copy link

coveralls commented May 2, 2025 •
edited
Loading

Coverage Status

coverage: 80.715% (+0.001%) from 80.714%
when pulling f1b050b on raju/public_error_message
into a62fdc6 on master.

junaed-optimizely
junaed-optimizely approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raju-opti raju-opti merged commit dd66bea into master May 5, 2025
16 of 17 checks passed
@raju-opti raju-opti deleted the raju/public_error_message branch May 5, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely