Skip to content

[FSSDK-11504] rename log level presets #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/common_exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ export { createStaticProjectConfigManager } from './project_config/config_manage
export { LogLevel } from './logging/logger';

export {
DebugLog,
InfoLog,
WarnLog,
ErrorLog,
DEBUG,
INFO,
WARN,
ERROR,
} from './logging/logger_factory';

export { createLogger } from './logging/logger_factory';
Expand Down
8 changes: 4 additions & 4 deletions lib/entrypoint.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ export type Entrypoint = {

// logger related exports
LogLevel: typeof LogLevel;
DebugLog: OpaqueLevelPreset,
InfoLog: OpaqueLevelPreset,
WarnLog: OpaqueLevelPreset,
ErrorLog: OpaqueLevelPreset,
DEBUG: OpaqueLevelPreset,
INFO: OpaqueLevelPreset,
WARN: OpaqueLevelPreset,
ERROR: OpaqueLevelPreset,
createLogger: (config: LoggerConfig) => OpaqueLogger;

// error related exports
Expand Down
8 changes: 4 additions & 4 deletions lib/entrypoint.universal.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ export type UniversalEntrypoint = {

// logger related exports
LogLevel: typeof LogLevel;
DebugLog: OpaqueLevelPreset,
InfoLog: OpaqueLevelPreset,
WarnLog: OpaqueLevelPreset,
ErrorLog: OpaqueLevelPreset,
DEBUG: OpaqueLevelPreset,
INFO: OpaqueLevelPreset,
WARN: OpaqueLevelPreset,
ERROR: OpaqueLevelPreset,
createLogger: (config: LoggerConfig) => OpaqueLogger;

// error related exports
Expand Down
2 changes: 1 addition & 1 deletion lib/event_processor/batch_event_processor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ describe('BatchEventProcessor', async () => {
batchSize: 100,
});

expect(processor.process(createImpressionEvent('id-1'))).rejects.toThrow();
await expect(processor.process(createImpressionEvent('id-1'))).rejects.toThrow();
});

it('should enqueue event without dispatching immediately', async () => {
Expand Down
6 changes: 3 additions & 3 deletions lib/logging/logger_factory.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ vi.mock('./logger', async (importOriginal) => {
});

import { OptimizelyLogger, ConsoleLogHandler, LogLevel } from './logger';
import { createLogger, extractLogger, InfoLog } from './logger_factory';
import { createLogger, extractLogger, INFO } from './logger_factory';
import { errorResolver, infoResolver } from '../message/message_resolver';

describe('create', () => {
Expand All @@ -41,7 +41,7 @@ describe('create', () => {
const mockLogHandler = { log: vi.fn() };

const logger = extractLogger(createLogger({
level: InfoLog,
level: INFO,
logHandler: mockLogHandler,
}));

Expand All @@ -56,7 +56,7 @@ describe('create', () => {

it('should use a ConsoleLogHandler if no logHandler is provided', () => {
const logger = extractLogger(createLogger({
level: InfoLog,
level: INFO,
}));

expect(logger).toBe(MockedOptimizelyLogger.mock.instances[0]);
Expand Down
8 changes: 4 additions & 4 deletions lib/logging/logger_factory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@ export type OpaqueLevelPreset = {
[levelPresetSymbol]: unknown;
};

export const DebugLog: OpaqueLevelPreset = {
export const DEBUG: OpaqueLevelPreset = {
[levelPresetSymbol]: debugPreset,
};

export const InfoLog: OpaqueLevelPreset = {
export const INFO: OpaqueLevelPreset = {
[levelPresetSymbol]: infoPreset,
};

export const WarnLog: OpaqueLevelPreset = {
export const WARN: OpaqueLevelPreset = {
[levelPresetSymbol]: warnPreset,
};

export const ErrorLog: OpaqueLevelPreset = {
export const ERROR: OpaqueLevelPreset = {
[levelPresetSymbol]: errorPreset,
};

Expand Down
2 changes: 1 addition & 1 deletion lib/project_config/polling_datafile_manager.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ describe('PollingDatafileManager', () => {
manager.start();
for(let i = 0; i < 2; i++) {
const ret = repeater.execute(0);
expect(ret).rejects.toThrow();
await expect(ret).rejects.toThrow();
}

repeater.execute(0);
Expand Down
Loading