[FSSDK-11158] update: add remove method in LRU Cache for CMAB service #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a remove method to the LRUCache class and includes corresponding tests to ensure it works under various conditions.
- Implement
removeinlib/optimizely/odp/lru_cache.rb - Add specs covering removal of existing keys, non-existent keys, zero-sized caches, re-adding keys, and thread safety in
spec/odp/lru_cache_spec.rb
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/optimizely/odp/lru_cache.rb | Added remove method to delete cache entries |
| spec/odp/lru_cache_spec.rb | New tests for remove behavior under multiple scenarios |
Mat001
approved these changes
Jul 16, 2025
FarhanAnjum-opti
deleted the
farhan-anjum/FSSDK-11158-update-cache-implementation-for-cmab
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added remove method in LRU cache class
Test plan
Added remove method in LRU cache class
Issues
FSSDK-11158