Skip to content

Conversation

@dvic
Copy link
Contributor

@dvic dvic commented Aug 11, 2025

Summary

Changes

  • Modified YmlEncoder to not apply the value/1 function to lines within multiline blocks
  • Added test case to verify multiline strings with colons work correctly

Test plan

  • All existing tests pass
  • Added new test for multiline strings containing colons
  • CI checks pass (formatting, Credo, Dialyzer)
  • 100% test coverage maintained

Removes unnecessary quoting of strings containing colons when they are
part of multiline YAML blocks by directly using the line content instead
of passing it through the value() function.

Fixes optimumBA#4
@dvic
Copy link
Contributor Author

dvic commented Aug 11, 2025

PR is by your truly Claude Opus 4.1 ;)

@almirsarajcic
Copy link
Member

You're absolutely right!

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dvic (and Opus 4.1)!

Tried it in my projects and there are no regressions, the exact same .yml files are generated for my workflows.

@almirsarajcic almirsarajcic merged commit 49890a2 into optimumBA:main Aug 13, 2025
4 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strings are quoted when containing double colon

2 participants