regex fix to support table name with alias #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ting-lan-wang
previously approved these changes
Oct 14, 2025
oracle/query.go
Outdated
|
|
||
| // Identifies the table name alias provided as | ||
| // "\"users\" \"u\"" and "\"users\" u". Gorm already handles | ||
| // "\"users\" \"u\"" and "\"users\" u" and "\"users\"". Gorm already handles |
There was a problem hiding this comment.
Sorry for retracting the approval at last minute.
I’m wondering why we need to specifically handle the case "users" without an alias.
It also looks like issue #71 still remains. Line 60 still appears to be unreachable.
ting-lan-wang
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue : #71