Skip to content

Remove filter #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: feature/model_group
Choose a base branch
from
Open

Remove filter #1280

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
700c269
Merge branch 'feature/model_group' of https://github.com/oracle/accel…
Aryanag2 Sep 17, 2025
e4ebbee
Merge branch 'feature/model_group' of https://github.com/oracle/accel…
Aryanag2 Sep 17, 2025
be5263c
Merge branch 'feature/model_group' of https://github.com/oracle/accel…
Aryanag2 Sep 22, 2025
d6d48f9
removed filter which blocks model deployments created from model grou…
Aryanag2 Oct 3, 2025
062335e
removed comments
Aryanag2 Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ads/aqua/modeldeployment/deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,11 +1507,11 @@ def list(self, **kwargs) -> List["AquaDeployment"]:

if oci_aqua:
# skipping the AQUA model deployments that are created from model group
if (
model_deployment.model_deployment_configuration_details.deployment_type
in [UNKNOWN_ENUM_VALUE, MODEL_GROUP, SINGLE_MODEL_FLEX]
):
continue
# if (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's delete these lines. Git will keep the history.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

# model_deployment.model_deployment_configuration_details.deployment_type
# in [UNKNOWN_ENUM_VALUE, MODEL_GROUP, SINGLE_MODEL_FLEX]
# ):
# continue
try:
results.append(
AquaDeployment.from_oci_model_deployment(
Expand Down