[GR-64965] Do not try to validate type state propagation into disabled flows #11192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
TypeFlow.validateFixedPointState
tries to propagate type state from a flow to its uses, it should only do so if the use is enabled, because the saturation callback methodsonInputSaturated
andonObservedSaturated
are only registered but not executed for disabled flows. Their execution is delayed until the flow becomes enabled. Therefore,TypeFlow.processInputState
, which in some cases (e.g. conditional flow) explicitly queries the state of its inputs and observees) might return a bigger value compared to the original state of the flow, which is actually valid behaviour in this case (as the saturation callbacks that can change the type state of the flow were not yet executed, because it is not enabled). We should therefore only try to propagate values into already enabled flows in the type flow graph validation.