Fix for Invalid Function Schema #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Member
There was a problem hiding this comment.
Can we use this straighforward fix instead of the complicated logic?
Fix:
In line 817 use "type": p_def.get("type", "string"), instead of "type": p_def.get("type", "any"), since most tool parameters are strings anyway.
|
|
||
| stop_sequence_key: str = "stop" | ||
|
|
||
| @staticmethod |
Member
There was a problem hiding this comment.
Why is this function under CohereProvider?
Member
There was a problem hiding this comment.
We can omit these unit tests if we just use the straightforward fix: "type": p_def.get("type", "string"),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing the following issue - #45
Thanks to @marancibia for helping test this fix.
In line 817
convert_to_oci_tooluses"type": p_def.get("type", "any"), which defaults to a non json-schema comatible Type. This causes an error on the tool invocation.https://json-schema.org/understanding-json-schema/reference/type
The recommendation for handling the type any from Json-object is to pass a list containing all types:
"any": ["string", "number", "integer", "boolean", "array", "object", "null"]
I am working to confirm that this is in-fact supported on OCI server side, otherwise I was considering defaulting to string or object as the Json Type. I also added a similar fix to recursively resolve Json Type for subclasses of BaseModel.