[BUGS] Fix CI Workflow Errors #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed check_diffs.yml to CI.yml and refactored workflow to remove dynamic directory detection, now explicitly linting and testing 'libs/oci' and 'libs/oracledb'. Updated Poetry version to 2.2.1 in all workflow files for consistency and added workflow_dispatch for manual CI triggers.
oracle-contributor-agreement
bot
added
the
OCA Verified
Simplify _lint.yml. Rephrase OCI code base to pass make lint checks.
Fix make lint error: tests/unit_tests/llms/test_oci_model_deployment_endpoint.py:60: error: Missing named argument "response" for "HTTPError" [call-arg] Found 1 error in 1 file (checked 29 source files)
Use Union type to pass make lint check: tests/integration_tests/vectorstores/test_oraclevs.py:1891: error: X | Y syntax for unions requires Python 3.10 [syntax] tests/integration_tests/vectorstores/test_oraclevs.py:2028: error: X | Y syntax for unions requires Python 3.10 [syntax] Found 2 errors in 1 file (checked 22 source files) make: *** [Makefile:33: lint] Error 1
Add LangGraph and related packages for integration tests.
Introduces a placeholder test in the OCI integration tests to ensure no errors are raised when no tests are selected.
Member
|
Seems like the lint and format has changed which caused a lot of unnecessary difference. @paxiaatucsdedu |
Member
Author
Have to change some lint and format to pass the make lint tests. @YouNeedCryDear |
Refactor to pass make lint checks
…b from the CI workflow Deleted test_placeholder.py files and the 'compile' pytest marker from both oci and oracledb libraries. Also removed the compile-integration-tests job from the CI workflow, as these placeholders are no longer needed.
This commit removes unnecessary '# noqa: E501' comments throughout the codebase and reformats long lines for improved readability. Docstrings, function signatures, and code examples have been wrapped or split across lines where appropriate. No functional changes were made.
Corrects the closing quote in the 'arguments' field of the test_meta_tool_calling test to ensure the escaped JSON is properly formatted.
Corrects the escaped JSON string in the 'arguments' field of the test_meta_tool_calling test to ensure proper formatting and accurate test coverage.
YouNeedCryDear
requested changes
Nov 13, 2025
libs/oci/tests/unit_tests/chat_models/test_oci_generative_ai.py
Outdated
Show resolved
Hide resolved
libs/oci/tests/unit_tests/chat_models/test_oci_generative_ai.py
Outdated
Show resolved
Hide resolved
libs/oci/tests/unit_tests/chat_models/test_oci_generative_ai.py
Outdated
Show resolved
Hide resolved
Split long error messages and test strings across multiple lines to improve readability and remove unnecessary noqa: E501 comments. Also reformatted SQL condition string construction in oraclevs.py for better clarity.
Eliminates the duplicate 'poetry check' command, leaving only 'poetry check --lock' to validate the Poetry configuration and lock file.
YouNeedCryDear
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolved CI workflow errors, lint errors, and integration test compile errors to ensure all checks pass for both libs/oci and libs/oracledb packages.
Problem
The existing CI workflow (check_diffs.yml) was failing due to:
The action ana06/[email protected] is not allowed in oracle/langchain-oracle because all actions must be from a repository owned by your enterprise, created by GitHub, or match one of the patterns: aquasecurity/setup-trivy*, aquasecurity/trivy-action*, docker/*, gradle/actions/wrapper-validation*, gradle/wrapper-validation-action*, microsoft/[email protected], ossf/scorecard-action*, ruby/setup-ruby*, slsa-framework/slsa-github-generator*.Make lint errors.
Compile-integration-test errors.
Solution
CI workflow
Fix make lint errors
Fix compile-integration-test errors