Azure Vault Config Provider: reject empty secret name #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fmeheust
reviewed
Jun 30, 2025
| @@ -70,12 +70,15 @@ static void parseVaultSecretUri( | |||
|
|
|||
| String path = urlBuilder.getPath(); | |||
|
|
|||
| if (!path.contains("/secrets")) | |||
| if (!path.contains("/secrets/")) | |||
| throw new IllegalArgumentException("The Vault Secret URI should " + | |||
| "contain \"/secrets\" following by the name of the Secret: " + | |||
There was a problem hiding this comment.
contain "/secrets" followed by the name of the Secret:
fmeheust
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #193
Reject URLs ending in
/secrets/with no name by validating inAzureVaultURLParserand throwing a clearIllegalArgumentException.Added a unit test to cover the empty‐name scenario.