Trim input helper aria-describedby whitespace#104
Open
jasperan wants to merge 2 commits intooracle:masterfrom
Open
Trim input helper aria-describedby whitespace#104jasperan wants to merge 2 commits intooracle:masterfrom
jasperan wants to merge 2 commits intooracle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #59 by trimming the
aria-describedbyvalue after appending input helper ids.Problem
ojinputtextcould leave leading or trailing whitespace inaria-describedbywhile appending helper ids. The issue report tied that malformed attribute value to jQuery validation failures after repeated date interactions.Reproduction
Trigger the
_AppendInputHelper()path onojInputTextand inspect the resultingaria-describedbyvalue.On the unfixed build, the helper path could produce
" helper-id"instead of"helper-id".Changes
aria-describedbystring before writing it backVerification
helper-idnpm pack --dry-runScope / Caveats