Skip to content

[WIP] Create a Ruby Class per foreign meta object #3155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Create a Ruby Class per foreign meta object #3155

wants to merge 1 commit into from

Conversation

graalvmbot
Copy link
Collaborator

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 10, 2023
@eregon eregon mentioned this pull request Jul 10, 2023
Open
nirvdrum
nirvdrum reviewed Aug 11, 2023
View reviewed changes
src/main/java/org/truffleruby/language/objects/ForeignClassNode.java
return rubyClass;
private static RubyClass classForTraits(Node node, Object object, int traits) {
return resolvePolyglotForeignClass(node, object, traits);
// RubyClass rubyClass = coreLibrary(node).polyglotForeignClasses[traits];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@nirvdrum nirvdrum nirvdrum left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graalvmbot @nirvdrum @eregon