Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle argument Socket::INADDR_ANY in Socket.sockaddr_in. #3364

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Properly handle argument Socket::INADDR_ANY in Socket.sockaddr_in. #3364

merged 2 commits into from
Jan 8, 2024

Conversation

mtortonesi
Copy link
Contributor

@mtortonesi mtortonesi commented Dec 30, 2023 •
edited by eregon
Loading

Fixes #3361.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 30, 2023
eregon
eregon approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Jan 3, 2024
@eregon eregon force-pushed the sockaddr_in_fixes branch 2 times, most recently from 003e5b9 to e1b4a31 Compare January 4, 2024 10:04
@graalvmbot graalvmbot merged commit 4516fc1 into oracle:master Jan 8, 2024
14 checks passed
@eregon eregon added this to the 24.0.0 Release (March 19, 2024) milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
in-ci The PR is being tested in CI. Do not push new commits. OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
24.0.0 Release (March 19, 2024)
Development

Successfully merging this pull request may close these issues.

Socket.sockaddr_in doesn't seem to work with integers.
4 participants
@mtortonesi @eregon @graalvmbot @andrykonchin