Skip to content

Conversation

@namudara1
Copy link

@namudara1 namudara1 commented Dec 8, 2025

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the capability to configure secondary labels for radio input fields, which are displayed in parentheses with reduced opacity (50%) next to the primary label. The feature allows developers to provide additional contextual information for radio options, such as "Full Time (40 hours/week)".

Key Changes:

  • Added secondaryLabel prop to RadioInput and RadioGroup components with proper TypeScript typing
  • Implemented visual styling for secondary labels with reduced opacity and spacing
  • Updated Storybook documentation with examples demonstrating the new feature

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
components/src/core/components/Input/RadioInput.vue Added secondaryLabel prop and rendered it conditionally in both left and right label positions
components/src/core/components/Input/RadioGroup.vue Extended Options interface with optional secondaryLabel field and passed it to RadioInput with translation support
components/src/core/components/Input/radio-input.scss Added styling for secondary label with 50% opacity and 0.25rem left margin
storybook/stories/core/components/Input/RadioInput.stories.js Added secondaryLabel control and new story demonstrating the feature
storybook/stories/core/components/Input/RadioGroup.stories.js Updated options documentation to include secondaryLabel and added comprehensive story example
changelog.md Documented the change with commit hash and affected files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@namudara1 namudara1 force-pushed the HT-964-radio-field-secondary-label branch from e82ac7c to cf00a10 Compare December 9, 2025 18:26
@namudara1 namudara1 force-pushed the HT-964-radio-field-secondary-label branch 3 times, most recently from bcb2c5c to 71168c9 Compare December 17, 2025 12:57
Copy link
Member

@Super-Chama Super-Chama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding few test to radio input to check if secondary label is showing as expected

@namudara1 namudara1 force-pushed the HT-964-radio-field-secondary-label branch from 71168c9 to 861cfb3 Compare December 18, 2025 09:45
@namudara1 namudara1 force-pushed the HT-964-radio-field-secondary-label branch from 861cfb3 to 43dda99 Compare December 18, 2025 09:55
@namudara1 namudara1 closed this Dec 18, 2025
@namudara1 namudara1 reopened this Dec 18, 2025
@Super-Chama Super-Chama merged commit 58c8f87 into orangehrm:ent Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants