-
Notifications
You must be signed in to change notification settings - Fork 71
HT-964: Provide capability to configure secondary label for radio fields #877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HT-964: Provide capability to configure secondary label for radio fields #877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the capability to configure secondary labels for radio input fields, which are displayed in parentheses with reduced opacity (50%) next to the primary label. The feature allows developers to provide additional contextual information for radio options, such as "Full Time (40 hours/week)".
Key Changes:
- Added
secondaryLabelprop to RadioInput and RadioGroup components with proper TypeScript typing - Implemented visual styling for secondary labels with reduced opacity and spacing
- Updated Storybook documentation with examples demonstrating the new feature
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
components/src/core/components/Input/RadioInput.vue |
Added secondaryLabel prop and rendered it conditionally in both left and right label positions |
components/src/core/components/Input/RadioGroup.vue |
Extended Options interface with optional secondaryLabel field and passed it to RadioInput with translation support |
components/src/core/components/Input/radio-input.scss |
Added styling for secondary label with 50% opacity and 0.25rem left margin |
storybook/stories/core/components/Input/RadioInput.stories.js |
Added secondaryLabel control and new story demonstrating the feature |
storybook/stories/core/components/Input/RadioGroup.stories.js |
Updated options documentation to include secondaryLabel and added comprehensive story example |
changelog.md |
Documented the change with commit hash and affected files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e82ac7c to
cf00a10
Compare
bcb2c5c to
71168c9
Compare
Super-Chama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding few test to radio input to check if secondary label is showing as expected
71168c9 to
861cfb3
Compare
861cfb3 to
43dda99
Compare
Checklist