chore: generate the Prisma client on postinstall - #22
Merged
Conversation
`src/generated/prisma` is gitignored and there was no postinstall hook, so a fresh clone, a CI job, or any `npm install` left the client missing — and `tsc --noEmit` reported 69 errors that had nothing to do with the code (`Property 'competitorCreative' does not exist on type 'PrismaClient'` and similar, 40 of them). A typecheck that is always red is a typecheck nobody reads, which is how a real error would get through. Adding `"postinstall": "prisma generate"` — the standard Prisma convention for a gitignored client. Verified end to end: delete src/generated/prisma → 173 errors; `npm install` → client regenerated → 0 errors, 414 tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsc --noEmitonmainreports 69 errors, none of them real:Cause:
src/generated/prismais gitignored and there is no postinstall hook — so a fresh clone, a CI job, or anynpm installleaves the client missing and the schema-derived types unresolvable.A typecheck that is always red is a typecheck nobody reads — which is exactly how a real error gets through. I hit this while reviewing #21 and had to diff the error sets against
mainto prove that PR introduced none of them.Fix is the standard Prisma convention:
"postinstall": "prisma generate".Verified end to end
src/generated/prismanpm install(postinstall fires)npm test→ 414 passed / 32 files.🤖 Generated with Claude Code