fix(cli): wire --permission-mode as a true alias for --mode - #159
Merged
Conversation
Previously --permission-mode was parsed and validated but stored into a separate ParsedArgs.permissionMode field that cli.ts never read (only args.mode is forwarded to the agent), so "deepcode --permission-mode plan" silently ran in the default mode with no feedback. It now sets out.mode directly, matching the documented "alias for --mode" semantics, and the dead permissionMode field is removed. Last flag wins when both --mode and --permission-mode are given. Adds parse-args tests for the alias and the last-wins precedence. docs/BEHAVIOR_PARITY.md already marks the combined --mode / --permission-mode row as supported; this fix makes that accurate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
oratis
added a commit
that referenced
this pull request
Jun 7, 2026
) Both flags were parsed (and parse-tested) but ignored: - --bare: suppress the REPL startup banner (▎ DeepCode line + "Working in" + "Type /help") for scripting / minimal output. - --no-plugins: skip plugin discovery (empty contributions) + wirePlugins — faster start, or to bypass a broken plugin. Threaded through ReplOpts → startRepl. Also flips stale BEHAVIOR_PARITY rows: --permission-mode → ✅ (already wired in #159), --bare → ✅, --no-plugins → 🟡 (--strict still parsed-only). Parsing is covered by the existing parse-args "boolean flags" test; the wiring is smoke-verified against a throwaway HOME (--bare → 0 banner lines vs 1 without; --bare/--no-plugins both run + exit cleanly). cli 137. Co-authored-by: t <t@t> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
oratis
added a commit
that referenced
this pull request
Aug 3, 2026
…version (#217) * fix(cli): stop advertising flags that do nothing, and ship the right version Three kinds of user-visible dishonesty, from docs/THREE_WAY_REVIEW.md F1-F4. Inert flags. `--agents`, `--mcp-config`, `--plugin-dir`, `--plugin-url` and `--strict` are parsed into ParsedArgs and consumed by nothing — but `--help` listed all five under OVERRIDES, so passing one looked like it worked. Same shape as the `--permission-mode` bug fixed in #159. They are now dropped from `--help` and reported on stderr when used; still accepted, so scripts that already pass them keep running instead of exiting 2. `--bare` copy. It claimed "No plugins / MCP / skills — just kernel + tools". It suppresses the startup banner. `--no-plugins` is the flag that disables plugins. Version. `deepcode --version` printed 0.1.0 — core's VERSION constant, which the release workflow never stamped, while it patched apps/cli/package.json (0.1.6) and the changelog announced 0.2.0. Every user-facing version string (`--version`, `--help`, `/upgrade`, the `/bug` issue body) was wrong on every release so far. All version fields move to 0.2.0, release.yml now stamps core before each build that embeds it, and a new scripts/version-consistency.test.ts fails CI if core, CLI, desktop, Cargo and the changelog ever disagree again. Positioning. The README stopped promising 1:1 Claude Code parity; the help header, two package descriptions and the migration guide had not. The migration guide also documented `/login` as nonexistent (it shipped in #157), `/rewind` as a skeleton, and the VS Code extension as a v1.1 skeleton. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(desktop): sync Cargo.lock with the crate version bump CI runs `cargo check --locked`, which fails when Cargo.lock still pins the old version. Also stamps the lock alongside Cargo.toml at release time, and extends the consistency test to cover it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: t <t@t> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--permission-modewas parsed and validated inparse-args.tsbut stored into aseparate
ParsedArgs.permissionModefield thatcli.tsnever reads — onlyargs.modeis forwarded to the agent (headless + REPL). Sodeepcode --permission-mode planwas accepted but silently ran in the defaultmode, with no feedback to the user.
docs/BEHAVIOR_PARITY.mdalready listed thecombined
--mode / --permission-moderow as ✅, ahead of the code.Fix
--permission-modenow setsout.modedirectly — a true alias for--mode,matching the documented "Alias for --mode (Claude Code parity)" help text.
permissionMode?: Modefield fromParsedArgs.--modeand--permission-modeare passed.Tests
parse-args.test.tscases: the alias setsmode(+ invalid value →unknownFlags), and--mode/--permission-modelast-flag-wins precedence.tsc -bclean, prettier clean.Makes the existing ✅ in
docs/BEHAVIOR_PARITY.mdaccurate rather than aspirational.🤖 Generated with Claude Code