Dev by remi-bezot · Pull Request #5 · organization-ai-projects/simulation_universe

remi-bezot · 2025-11-25T14:43:58Z

No description provided.

…ule-stabilization Feature/multi module stabilization

…ule-stabilization chore: remove obsolete release.yml and update Cargo.lock

…ule-stabilization fix(workflows): update token usage for GitHub Actions

Copilot

Pull request overview

This PR merges development work that adds a nutrient system to the 3D voxel world simulation, enhances the biology module with population merging and nutrient-based growth limits, and introduces CI/CD workflows for automated releases. The changes bump the version from 0.1.0 to 0.2.0.

Key Changes:

Added a nutrients field to the Voxel struct with default values for different materials (soil: 10.0, water: 5.0)
Implemented nutrient consumption and carrying capacity mechanics in the biology simulation
Added population merging logic to consolidate populations at the same location
Introduced GitHub Actions workflows for automated stable and beta releases

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`src/world3d.rs`	Added `nutrients` field to `Voxel` struct and updated all constructor methods to initialize nutrients with material-specific defaults
`src/biology.rs`	Implemented population merging, nutrient-based carrying capacity, nutrient consumption mechanics, and increased minimum migration threshold from 0 to 10
`Cargo.toml`	Version bump from 0.1.0 to 0.2.0
`Cargo.lock`	Updated version to match Cargo.toml
`CHANGELOG.md`	Added changelog entries documenting the new features and improvements in version 0.2.0
`.github/workflows/release-stable.yml`	New workflow for automatic stable releases on pushes to main branch
`.github/workflows/release-beta.yml`	New workflow for automatic beta releases on pushes to dev branch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-25T14:48:19Z

src/world3d.rs

    pub material: VoxelMaterial,
    pub temperature: f32,
    pub density: f32,
+    pub nutrients: f32, // Ajout des nutriments


These comments are in French, but the codebase uses English for all other documentation and comments (e.g., in main.rs and existing world3d.rs comments). For consistency and broader accessibility, please translate these to English. For example: "Ajout des nutriments" → "Addition of nutrients".

Copilot · 2025-11-25T14:48:19Z

src/world3d.rs

+        Self::new(VoxelMaterial::Soil, 18.0, 1.2, 10.0) // Ajout de nutriments par défaut pour le sol
    }

    pub fn water() -> Self {
-        Self::new(VoxelMaterial::Water, 10.0, 1.0)
+        Self::new(VoxelMaterial::Water, 10.0, 1.0, 5.0) // Ajout de nutriments par défaut pour l'eau


These comments are in French, but the codebase uses English for all other documentation and comments. For consistency and broader accessibility, please translate these to English. For example: "Ajout de nutriments par défaut pour le sol" → "Default nutrients for soil".

Copilot · 2025-11-25T14:48:19Z

src/biology.rs

+    // Fusionner les populations proches sur le même voxel
+    let mut population_map = std::collections::HashMap::new();
+
+    // Ajouter les populations existantes au map
+    for pop in populations.iter() {
+        let key = (pop.x, pop.y, pop.z, pop.species_id);
+        population_map
+            .entry(key)
+            .and_modify(|existing_size| *existing_size += pop.size)
+            .or_insert(pop.size);
+    }
+
+    // Ajouter les nouvelles populations au map
+    for pop in new_populations.iter() {
+        let key = (pop.x, pop.y, pop.z, pop.species_id);
+        population_map
+            .entry(key)
+            .and_modify(|existing_size| *existing_size += pop.size)
+            .or_insert(pop.size);
+    }
+
+    // Reconstruire la liste des populations
+    populations.clear();
+    for ((x, y, z, species_id), size) in population_map {
+        populations.push(Population::new(species_id, x, y, z, size));
+    }


The population merging logic at the beginning of the function clears the original populations vector (line 77) and rebuilds it from the HashMap. However, this happens before the retain_mut closure processes populations. This means all populations are being reset before any simulation logic runs, which likely breaks the intended flow. The merging logic should either:

Run after the retain_mut closure to merge newly created populations with existing ones, or

Be restructured to preserve the simulation state correctly.

Copilot · 2025-11-25T14:48:20Z

.github/workflows/release-beta.yml

+      - name: Create GitHub Beta Release
+        uses: actions/create-release@v1
+        with:
+          tag_name: ${{ steps.beta.outputs.new_beta_tag }}
+          release_name: Beta ${{ steps.beta.outputs.new_beta_tag }}
+          body: |
+            Beta build from dev.
+          draft: false
+          prerelease: true
+        env:
+          GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}


The actions/create-release@v1 action is deprecated and no longer maintained. GitHub recommends migrating to the newer softprops/action-gh-release or using the GitHub CLI (gh release create). The deprecated action may stop working in the future.

Copilot · 2025-11-25T14:48:20Z

src/biology.rs

+                && new_z < world.depth as i32
+            {
+                // Diviser la population : une partie reste, l'autre se déplace
                let moving_size = pop.size / 2;


Changing the population movement threshold from > 0 to > 10 prevents small populations from migrating. This is a significant behavioral change that should be documented in the changelog or explained with a comment, as it affects the simulation dynamics and may prevent small populations from colonizing new areas.

Suggested change

let moving_size = pop.size / 2;

let moving_size = pop.size / 2;

// Only allow migration if the moving population is greater than 10.

// This threshold prevents small populations from migrating, which may

// affect the ability of small populations to colonize new areas and

// changes the simulation dynamics. Adjust with care.

Copilot · 2025-11-25T14:48:20Z

src/biology.rs

+    // Ajouter les nouvelles populations au map
+    for pop in new_populations.iter() {
+        let key = (pop.x, pop.y, pop.z, pop.species_id);
+        population_map
+            .entry(key)
+            .and_modify(|existing_size| *existing_size += pop.size)
+            .or_insert(pop.size);
+    }


The new_populations vector is empty at this point (initialized on line 53), so this loop iterating over it will never execute. This code should be moved to after the retain_mut closure (before line 188) where new_populations is actually populated with new entries. The current placement makes the population merging logic ineffective for newly created populations.

Copilot · 2025-11-25T14:48:21Z

src/biology.rs

+            if new_x >= 0
+                && new_y >= 0
+                && new_z >= 0
+                && new_x < world.width as i32
+                && new_y < world.height as i32
+                && new_z < world.depth as i32
+            {


This validation logic duplicates the existing is_valid method available on World3D. Consider using world.is_valid(new_x, new_y, new_z) instead of this manual check for consistency and maintainability.

Suggested change

if new_x >= 0

&& new_y >= 0

&& new_z >= 0

&& new_x < world.width as i32

&& new_y < world.height as i32

&& new_z < world.depth as i32

{

if world.is_valid(new_x, new_y, new_z) {

Copilot · 2025-11-25T14:48:21Z

.github/workflows/release-stable.yml

+        uses: actions/create-release@v1
+        with:
+          tag_name: ${{ steps.version.outputs.new_tag }}
+          release_name: Release ${{ steps.version.outputs.new_tag }}
+          body: |
+            Stable release ${{ steps.version.outputs.new_tag }}.
+          draft: false
+          prerelease: false
+        env:
+          GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}


The actions/create-release@v1 action is deprecated and no longer maintained. GitHub recommends migrating to the newer softprops/action-gh-release or using the GitHub CLI (gh release create). The deprecated action may stop working in the future.

Suggested change

uses: actions/create-release@v1

with:

tag_name: ${{ steps.version.outputs.new_tag }}

release_name: Release ${{ steps.version.outputs.new_tag }}

body: |

Stable release ${{ steps.version.outputs.new_tag }}.

draft: false

prerelease: false

env:

GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

uses: softprops/action-gh-release@v1

with:

tag_name: ${{ steps.version.outputs.new_tag }}

name: Release ${{ steps.version.outputs.new_tag }}

body: |

Stable release ${{ steps.version.outputs.new_tag }}.

draft: false

prerelease: false

env:

GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Copilot · 2025-11-25T14:48:21Z

src/biology.rs

 ) {
    let mut rng = rand::thread_rng();
-    let mut new_populations = Vec::new();
+    let mut new_populations: Vec<Population> = Vec::new();


[nitpick] The explicit type annotation : Vec<Population> is redundant here since the type can be inferred from Vec::new(). Rust's type inference makes this unnecessary unless there's ambiguity.

Suggested change

let mut new_populations: Vec<Population> = Vec::new();

let mut new_populations = Vec::new();

remi-bezot and others added 9 commits November 25, 2025 12:58

feat(biology): add population merging and nutrient-based growth limits

be30ba8

chore(release): prepare for version 0.2.0 with GitHub Actions

ffd1d97

docs(changelog): add changelog for version 0.2.0 and include workflows

4acfac7

Merge pull request #1 from organization-ai-projects/feature/multi-mod…

1e5570f

…ule-stabilization Feature/multi module stabilization

chore: remove obsolete release.yml and update Cargo.lock

5c3884a

Merge pull request #2 from organization-ai-projects/feature/multi-mod…

f4abae8

…ule-stabilization chore: remove obsolete release.yml and update Cargo.lock

Merge branch 'main' into dev

9eb8906

fix(workflows): update token usage for GitHub Actions

820feec

Merge pull request #4 from organization-ai-projects/feature/multi-mod…

a28dd3d

…ule-stabilization fix(workflows): update token usage for GitHub Actions

Copilot AI review requested due to automatic review settings November 25, 2025 14:43

remi-bezot merged commit c79e4ce into main Nov 25, 2025
3 checks passed

Copilot started reviewing on behalf of remi-bezot November 25, 2025 14:44 View session

Copilot finished reviewing on behalf of remi-bezot November 25, 2025 14:46

Copilot AI reviewed Nov 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#5

Dev#5
remi-bezot merged 9 commits intomainfrom
dev

remi-bezot commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Copilot AI Nov 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-                let moving_size = pop.size / 2;
+                let moving_size = pop.size / 2;
+                // Only allow migration if the moving population is greater than 10.
+                // This threshold prevents small populations from migrating, which may
+                // affect the ability of small populations to colonize new areas and
+                // changes the simulation dynamics. Adjust with care.

	let mut new_populations: Vec<Population> = Vec::new();
	let mut new_populations = Vec::new();

Conversation

remi-bezot commented Nov 25, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants